dev-doctor: Bump minimum hub version requirement for backporting #16734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twpayne
added
release-note/misc
aditighag
reviewed
Jul 1, 2021
| @@ -187,7 +187,7 @@ func rootCmdRun(cmd *cobra.Command, args []string) { | |||
| ifNotFound: checkError, | |||
| versionArgs: []string{"--version"}, | |||
| versionRegexp: regexp.MustCompile(`hub\s+version\s+(\d+.\d+\.\d+)`), | |||
| minVersion: &semver.Version{Major: 2, Minor: 0, Patch: 0}, | |||
| minVersion: &semver.Version{Major: 2, Minor: 14, Patch: 0}, | |||
There was a problem hiding this comment.
While at it, shall we also suggest steps to install this particular version?
There was a problem hiding this comment.
Good idea - added hint.
Backporting scripts need a version of github.com/github/hub that support the api command. The version of hub distributed with Ubuntu 20.04 LTS is 2.7.0, which is too old. Bump the minimum hub version to 2.14 as this is definitely new enough and was released 18 months ago. Signed-off-by: Tom Payne <tom@isovalent.com>
twpayne
force-pushed
the
pr/twpayne/dev-doctor-backporting-hub
branch
from
56c951b
to
67846ac
Compare
aditighag
reviewed
Jul 1, 2021
| @@ -187,7 +187,8 @@ func rootCmdRun(cmd *cobra.Command, args []string) { | |||
| ifNotFound: checkError, | |||
| versionArgs: []string{"--version"}, | |||
| versionRegexp: regexp.MustCompile(`hub\s+version\s+(\d+.\d+\.\d+)`), | |||
| minVersion: &semver.Version{Major: 2, Minor: 0, Patch: 0}, | |||
| minVersion: &semver.Version{Major: 2, Minor: 14, Patch: 0}, | |||
| hint: `Download the latest version from https://github.com/github/hub/releases.`, | |||
There was a problem hiding this comment.
This doesn't seem to have installation steps. Perhaps this link - https://github.com/github/hub? I'll leave it to you.
There was a problem hiding this comment.
The https://github.com/github/hub link actually contains incorrect installation steps for us. It recommends installing hub with your distro's package manager, which will generally get you a version of hub that's too old.
aditighag
approved these changes
Jul 1, 2021
twpayne
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting scripts need a version of github.com/github/hub that support
the api command. The version of hub distributed with Ubuntu 20.04 LTS is
2.7.0, which is too old. Bump the minimum hub version to 2.14 as this is
definitely new enough and was released 18 months ago.
Signed-off-by: Tom Payne tom@isovalent.com