New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve the bandwidth manager page #16783
docs: improve the bandwidth manager page #16783
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the backports really already pending? Or should that be needs-backport/xxx
? I don't see any other PRs referencing this PR, and if this PR isn't merged yet then the backporting scripts won't pick this up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few small nits
@bmcustodio were you planning to get back to this? |
I've updated the labels to reflect that this PR will need backporting, since I couldn't tell if the backport process was already kicked off somewhere. If you have started backporting them, then feel free to set the labels back to |
Attempts to make the "Bandwidth Manager" page more user-friendly by deploying a server pod and a client pod that is guaranteed to not be colocated with the former. Also provides friendlier commands for making the 'netperf' test, as well as to check the status of the bandwidth manager. Signed-off-by: Bruno Miguel Custódio <brunomcustodio@gmail.com>
Signed-off-by: Bruno Miguel Custódio <brunomcustodio@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like @borkmann 's review comments have been addressed. Should be good to merge now.
Attempts to make the "Bandwidth Manager" page more user-friendly by deploying a server pod and a client pod that is guaranteed to not be colocated with the former. Also provides friendlier commands for making the
netperf
test, as well as to check the status of the bandwidth manager.Related to this PR is #16782, but the current one needs backporting to both
v1.9
andv.10
, whereas #16782 is only required to be backported tov1.10
.