ci: run verifier tests with proper Go toolchain version #27857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
added
kind/bug/CI
|
/ci-verifier |
ldelossa
approved these changes
Aug 31, 2023
|
/test |
tklauser
force-pushed
the
pr/tklauser/ci-verifier
branch
from
254d6ba
to
8439b0f
Compare
|
/test |
Currently, the verifier tests are built and run with whatever Go toolchain version the LVH images ship. To make sure these tests are run with the same Go toolchain version as the rest of the tests install a copy of that Go toolchain before running the test. This wasn't caught in CI on #27820 because the verifier workflow wasn't run passed on the ariane exclusion list. Reported-by: Julian Wiedmann <jwi@isovalent.com> Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
force-pushed
the
pr/tklauser/ci-verifier
branch
from
8439b0f
to
c166510
Compare
|
/ci-verifier |
brb
approved these changes
Sep 1, 2023
aanm
approved these changes
Sep 1, 2023
giorio94
added
needs-backport/1.12
needs-backport/1.13
|
Marked for backport to all stable branches (except v1.15 which already includes it), as we are starting to hit the same issue there too: https://github.com/cilium/cilium/actions/runs/7623179184/job/20762689062 |
This was referenced Jan 23, 2024
giorio94
added
backport-pending/1.14
This was referenced Jan 23, 2024
The workflow does not appear to exist in v1.12 and v1.13. Removing the needs-backport label for these branches. |
giorio94
removed
needs-backport/1.12
needs-backport/1.13
github-actions
bot
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the verifier tests are built and run with whatever Go toolchain version the LVH images ship. To make sure these tests are run with the same Go toolchain version as the rest of the tests install a copy of that Go toolchain before running the test.
This wasn't caught in CI on #27820 because the verifier workflow wasn't run passed on the ariane exclusion list.
Reported-by: @julianwiedmann