Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci datapath-verifier: add connectivity test #29633

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

mhofstetter
Copy link
Member

@mhofstetter mhofstetter commented Dec 5, 2023

This commit adds a temporary connectivity test to the LVH GitHub Action command.

This checks whether golang.org is resolvable - and therefore systemd-resolved ready.

This prevents the actual download of Go from failing.

Fixes: #29543
Should unblock: #29556

This commit adds a temporary connectivity test to the LVH GitHub
Action command.

This checks whether golang.org is resolvable - and therefore
`systemd-resolved` ready.

This prevents the actual download of Go to fail.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Dec 5, 2023
@mhofstetter mhofstetter requested review from brb and aanm December 5, 2023 15:48
@mhofstetter mhofstetter marked this pull request as ready for review December 5, 2023 15:49
@mhofstetter mhofstetter requested review from a team as code owners December 5, 2023 15:49
@aanm
Copy link
Member

aanm commented Dec 5, 2023

/ci-verifier

Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing technology

@brb brb added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 6, 2023
@brb brb enabled auto-merge December 6, 2023 09:52
@aanm aanm disabled auto-merge December 6, 2023 11:51
@aanm aanm merged commit 8c82b9e into main Dec 6, 2023
53 checks passed
@aanm aanm deleted the pr/mhofstetter/datapath-verifier-conn-check branch December 6, 2023 11:51
@giorio94 giorio94 mentioned this pull request Jan 23, 2024
4 tasks
@giorio94
Copy link
Member

Marked for backport to all stable branches as it fixes #27857, which is being backported as well.

@giorio94 giorio94 added needs-backport/1.12 backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.12 labels Jan 23, 2024
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
Status: Released
Development

Successfully merging this pull request may close these issues.

Unable to upgrade LVH images tests-datapath-verifier.yaml
5 participants