v1.14 Backports 2024-01-23 #30371
Merged
v1.14 Backports 2024-01-23 #30371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit bb3eec4 ] Currently, the verifier tests are built and run with whatever Go toolchain version the LVH images ship. To make sure these tests are run with the same Go toolchain version as the rest of the tests install a copy of that Go toolchain before running the test. This wasn't caught in CI on #27820 because the verifier workflow wasn't run passed on the ariane exclusion list. Reported-by: Julian Wiedmann <jwi@isovalent.com> Signed-off-by: Tobias Klauser <tobias@cilium.io> Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
[ upstream commit bb4c241 ] The LVH images don't have GCC, so we need to explicitly disable cgo. This fixes the following failure: # runtime/cgo _cgo_export.c:3:10: fatal error: stdlib.h: No such file or directory 3 | #include <stdlib.h> | ^~~~~~~~~~ compilation terminated. Fixes: bb3eec4 ("ci: run verifier tests with proper Go toolchain version") Signed-off-by: Tobias Klauser <tobias@cilium.io> Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
[ upstream commit e263ddf ] Directly access golang.org/dl to avoid errors such as > go: golang.org/dl/go1.21.4@latest: module golang.org/dl/go1.21.4: Get "https://proxy.golang.org/golang.org/dl/go1.21.4/@v/list": dial tcp: lookup proxy.golang.org on 127.0.0.53:53: server misbehaving > Error: Process completed with exit code 1. Reported-by: Julian Wiedmann <jwi@isovalent.com> Signed-off-by: Tobias Klauser <tobias@cilium.io> Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
added
kind/backports
|
/ci-verifier |
[ upstream commit 8c82b9e ] This commit adds a temporary connectivity test to the LVH GitHub Action command. This checks whether golang.org is resolvable - and therefore `systemd-resolved` ready. This prevents the actual download of Go to fail. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com> Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
|
/ci-verifier |
viktor-kurchenko
approved these changes
Jan 23, 2024
markpash
approved these changes
Jan 23, 2024
|
The |
giorio94
added
the
ready-to-merge
1 task
|
/test-backport-1.14 |
|
Conformance AKS and Cilium IPsec upgrade failed, but both are not marked as required. I'd not consider them blocking for merging this PR, given that it only touches another unrelated workflow. In any case, I'll triage them in a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting ci-verifier fixes to address the failure observed in #30355:
Once this PR is merged, a GitHub action will update the labels of these PRs: