ci-ipsec-{e2e,upgrade}: Use lvh-kind #29514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brb
added
area/CI-improvement
|
/ci-ipsec-e2e |
brb
force-pushed
the
pr/brb/lvh-kind-ipsec
branch
from
5aa3de1
to
1b72df7
Compare
|
/ci-ipsec-e2e |
1 similar comment
|
/ci-ipsec-e2e |
brb
force-pushed
the
pr/brb/lvh-kind-ipsec
branch
from
1b72df7
to
28dd578
Compare
|
/ci-ipsec-e2e |
brb
force-pushed
the
pr/brb/lvh-kind-ipsec
branch
from
28dd578
to
9aba213
Compare
|
/ci-ipsec-e2e |
brb
force-pushed
the
pr/brb/lvh-kind-ipsec
branch
from
9aba213
to
88969c3
Compare
|
/ci-ipsec-e2e |
brb
force-pushed
the
pr/brb/lvh-kind-ipsec
branch
from
88969c3
to
2b337d6
Compare
|
/ci-ipsec-e2e |
jschwinger233
approved these changes
Dec 4, 2023
brb
force-pushed
the
pr/brb/lvh-kind-ipsec
branch
from
2b337d6
to
12eca7a
Compare
giorio94
pushed a commit
that referenced
this pull request
Dec 13, 2023
[ upstream commit 6ae9354 ] [ backporter's notes: hit minor conflict because #29514 has not yet been backported. Skipped the hunk for "Set Kind params". ] The workflow to test upgrades/downgrades with IPsec supports two cases: upgrading from the last minor version, or from the last patch release. In the case of patch releases, there are instances where we are not able to determine the latest patch releases. This is the case on the current development branch, where no patch releases have been created yet, for example. In such a case, we skip most of the steps in the job. When implementing the check on the patch release value and the bypass of the relevant steps, we omitted to skip the step where we wait for the CI images to be available, potentially causing unnecessary wait time for the job. Let's skip this step as well. Since we're at it, we can also skip the step for setting Kind parameters. Fixes: c9dedb4 ("ci/ipsec: Skip upgrade/downgrade test to patch release on main branch") Fixes: cd93d37 ("ci-ipsec-upgrade: Use lvh-kind") Reported-by: Paul Chaignon <paul.chaignon@gmail.com> Signed-off-by: Quentin Monnet <quentin@isovalent.com> Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
|
When doing the backports for this PR, please add #29793 on top of it. |
This was referenced Dec 13, 2023
qmonnet
added
backport-pending/1.14
qmonnet
added
backport-pending/1.13
github-actions
bot
added
backport-done/1.14
github-actions
bot
added
backport-done/1.13
gentoo-root
moved this from Needs backport from main
to Backport done to v1.13
in 1.13.11
gentoo-root
moved this from Needs backport from main
to Backport done to v1.14
in 1.14.6
This was referenced Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparatory work before refactoring ci-ipsec-{e2e,upgrade} testing part into a separate GH action.
Successful runs: