ci/ipsec: Skip waiting for images when skipping upgrade/dowgrade #29793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmonnet
added
kind/bug/CI
|
/ci-ipsec-upgrade |
The workflow to test upgrades/downgrades with IPsec supports two cases: upgrading from the last minor version, or from the last patch release. In the case of patch releases, there are instances where we are not able to determine the latest patch releases. This is the case on the current development branch, where no patch releases have been created yet, for example. In such a case, we skip most of the steps in the job. When implementing the check on the patch release value and the bypass of the relevant steps, we omitted to skip the step where we wait for the CI images to be available, potentially causing unnecessary wait time for the job. Let's skip this step as well. Since we're at it, we can also skip the step for setting Kind parameters. Fixes: c9dedb4 ("ci/ipsec: Skip upgrade/downgrade test to patch release on main branch") Fixes: cd93d37 ("ci-ipsec-upgrade: Use lvh-kind") Reported-by: Paul Chaignon <paul.chaignon@gmail.com> Signed-off-by: Quentin Monnet <quentin@isovalent.com>
qmonnet
force-pushed
the
pr/qmonnet/ipsec/skip-image-wait
branch
from
ad25894
to
9dc6187
Compare
|
/ci-ipsec-upgrade |
|
|
pchaigno
approved these changes
Dec 11, 2023
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
qmonnet
added
the
backport/author
|
Marked as backport/author as it needs to be backported after #29514. |
giorio94
added
backport-pending/1.13
qmonnet
added
backport-pending/1.14
qmonnet
added
backport-pending/1.13
github-actions
bot
added
backport-done/1.14
github-actions
bot
added
backport-done/1.13
This was referenced Jan 17, 2024
julianwiedmann
added
affects/v1.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow to test upgrades/downgrades with IPsec supports two cases: upgrading from the last minor version, or from the last patch release. In the case of patch releases, there are instances where we are not able to determine the latest patch releases. This is the case on the current development branch, where no patch releases have been created yet, for example. In such a case, we skip most of the steps in the job.
When implementing the check on the patch release value and the bypass of the relevant steps, we omitted to skip the step where we wait for the CI images to be available, potentially causing unnecessary wait time for the job. Let's skip this step as well.
Fixes: c9dedb4 ("ci/ipsec: Skip upgrade/downgrade test to patch release on main branch")
Reported at #28815 (comment)