v1.13 Backports 2023-12-13 #29847
v1.13 Backports 2023-12-13 #29847
Conversation
[ upstream commit a2694fc ] [ backporter's notes: skipped changes in conformance-ginkgo.yaml, conformance-runtime.yaml, tests-datapath-verifier.yaml and tests-e2e-upgrade.yaml, as not present in v1.13. ] The property dns-resolver has been removed from the little-vm-helper GitHub action. Therefore, this commit removes the usage of it in the cilium repository. See: cilium/little-vm-helper#118 Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com> Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
[ upstream commit 1f1c384 ] Cloud provider related workflows use the full configuration as matrix when being executed on a scheduled basis on stable branches, whereas only the default configuration is used on PR workflows. Currently, this decision checks whether the workflow is triggered via `event_name == schedule`. This is working fine on `main`, but not on all other stable branches where the workflows are triggered via workflow_dispatch event (called by a scheduled workflow (ariane-scheduled.yaml) on main). Therefore, this commit extends the decision to check for the input `PR-number` starting with a "v". This is the case for Ariane triggered runs - as they pass the branch name as PR-number (PR runs pass the actual numeric PR number). Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com> Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
[ upstream commit dbe56dd ] Now that known issues causing connection disruption (which appeared to mostly affect dual stack clusters) have been fixed, let's enable IPv6 again in the clustermesh upgrade/downgrade workflow. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com> Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
added
kind/backports
giorio94
requested review from
mhofstetter and
qmonnet
and removed request for
qmonnet
|
@mhofstetter It seems to me that 010f9ee may break CI, because some of the images have been created before cilium/little-vm-helper-images#187 was merged. In particular, bpf-next ones, which are not bumped automatically. I initially thought we needed to bump the action version (and opened #29850), but that is not enough as the images themselves need to be updated. On the contrary, bumping the action may break CI as well, due to the removal of the If this matches your understanding, do you have any ideas how to address it? /cc @brb Would it be possible upgrading the bpf-next images, or should we stick to the previous LVH action version? |
@giorio94 Good point. But potential issues should be detected when executing the CI test runs. If so, I agree that we should skip this backport and update the LVH images first. As for breaking CI when upgrading the action: This shouldn't be the case because the use of undefined parameters only results in warnings. This was also the original reason why @tklauser added the backport labels for the related PR: #29455 (comment) |
Yeah, let's run it and decide based on the outcome.
Sure. What I meant is that if this one breaks CI, that would as well, because the |
|
/test-backport-1.13 |
GHA-based CI looks green (except for the ipsec known flake) 🚀 |
|
Conformance GKE failed due to node churn caused by spot instances. Rerunning |
|
/test-1.24-4.19 |
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
Cilium IPsec upgrade failure is a known flake, and the check is not marked as required: #29702. This is good to be merged. |
ci/ipsec: Skip waiting for images when skipping upgrade/dowgrade #29793 (@qmonnet)Dropped, as it depends on ci-ipsec-{e2e,upgrade}: Use lvh-kind #29514 (backport/author)Once this PR is merged, a GitHub action will update the labels of these PRs: