Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency cilium/cilium-cli to v0.16.3 (v1.14) #31465

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 18, 2024

Mend Renovate

This PR contains the following updates:

Package Type Update Change
cilium/cilium-cli patch v0.16.0 -> v0.16.3
cilium/cilium-cli action patch v0.16.0 -> v0.16.3

Release Notes

cilium/cilium-cli (cilium/cilium-cli)

v0.16.3

Compare Source

v0.16.2

Compare Source

What's Changed

New Contributors

Full Changelog: cilium/cilium-cli@v0.16.1...v0.16.2

v0.16.1

Compare Source

What's Changed

New Contributors

Full Changelog: cilium/cilium-cli@v0.16.0...v0.16.1


Configuration

📅 Schedule: Branch creation - "on monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Signed-off-by: renovate[bot] <bot@renovateapp.com>
@renovate renovate bot requested a review from a team as a code owner March 18, 2024 20:02
@renovate renovate bot added the kind/enhancement This would improve or streamline existing functionality. label Mar 18, 2024
@renovate renovate bot requested a review from a team as a code owner March 18, 2024 20:02
@renovate renovate bot added the release-note/misc This PR makes changes that have no direct user impact. label Mar 18, 2024
@renovate renovate bot requested a review from a team as a code owner March 18, 2024 20:02
@renovate renovate bot added the renovate/stop-updating Tell Renovate to stop updating PR label Mar 18, 2024
@renovate renovate bot requested a review from a team as a code owner March 18, 2024 20:02
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.14 This PR represents a backport for Cilium 1.14.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels Mar 18, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Mar 18, 2024
@michi-covalent michi-covalent self-assigned this Mar 18, 2024
The --nodes-without-cilium flag type changed from string slice to
boolean in cilium/cilium-cli#2427.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent
Copy link
Contributor

/test-backport-1.14

@michi-covalent
Copy link
Contributor

@sayboras
Copy link
Member

i guess this is a legitimate failure? 💭 https://github.com/cilium/cilium/actions/runs/8334168823/job/22807589092#step:20:34

It is, however, I can merge this cilium-cli bump PR with my KPR cleanup to get around it.

#31286

@sayboras
Copy link
Member

It is, however, I can merge this cilium-cli bump PR with my KPR cleanup to get around it.

Ah sorry, this is for v1.14, so we can't backport my clean up PR :(

@michi-covalent
Copy link
Contributor

that's a devastating news. what do we do

@giorio94
Copy link
Member

that's a devastating news. what do we do

Hmm, it shouldn't be difficult to override. Let me take a look

Cilium v1.13 allowed configuring KPR using the disabled/partial/strict
settings, while v1.14 deprecated them in favor of false/true. Let's
update the clustermesh upgrade/downgrade workflow to make sure that
we use the appropriate setting depending on whether we are installing
Cilium v1.13 or v1.14.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94
Copy link
Member

/test-backport-1.14

@giorio94
Copy link
Member

Cilium Cluster Mesh upgrade (ci-clustermesh) is green now.

@sayboras
Copy link
Member

Cilium Cluster Mesh upgrade (ci-clustermesh) is green now.

😲 you are just amazing

Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of sig-scalability.

@giorio94 giorio94 removed the request for review from thorn3r March 19, 2024 10:29
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 19, 2024
@julianwiedmann julianwiedmann merged commit 6650740 into v1.14 Mar 19, 2024
222 checks passed
@julianwiedmann julianwiedmann deleted the renovate/v1.14-cilium-cli branch March 19, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.14 This PR represents a backport for Cilium 1.14.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. kind/community-contribution This was a contribution made by a community member. kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. renovate/stop-updating Tell Renovate to stop updating PR
Projects
No open projects
Status: Released
Development

Successfully merging this pull request may close these issues.

None yet

6 participants