Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: replace Memoize with sync.OnceValues (Go 1.21) #1199

Closed
lmb opened this issue Nov 2, 2023 · 1 comment
Closed

internal: replace Memoize with sync.OnceValues (Go 1.21) #1199

lmb opened this issue Nov 2, 2023 · 1 comment
Assignees
@kwakubiney
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@lmb
Copy link
Collaborator

lmb commented Nov 2, 2023

Go 1.21 added https://pkg.go.dev/sync#OnceValues. Replace our home grown internal.Memoize with it.
@lmb lmb added enhancement New feature or request help wanted Extra attention is needed labels Nov 2, 2023
@lmb lmb mentioned this issue Nov 14, 2023
Merged
@lmb lmb added good first issue Good for newcomers and removed help wanted Extra attention is needed labels Nov 16, 2023
@kwakubiney kwakubiney self-assigned this Nov 28, 2023
@kwakubiney kwakubiney mentioned this issue Nov 28, 2023
Merged
@rgo3
Copy link
Contributor

rgo3 commented Feb 15, 2024

Closing, as #1240 was merged.

@rgo3 rgo3 closed this as completed Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kwakubiney kwakubiney

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Good First Issues
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lmb @rgo3 @kwakubiney