-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
small improvements for the log, popup, and whitelist #19
Comments
You mean when a domain is whitelisted, remove all the items in the list with that domain? Because there shouldn't be new ones any way. |
Done part one. I'll try to get around to making the popup nicer, and filter the list by the current tab. I think that makes more sense than current domain, in case some other/sub domain makes a request (through an iframe or whatnot). |
Or at least a clear button on the log. As I browse around it accrues a laundry list of cleaned links. When I have an issue that needs whitelisting I have to sift through a bunch of old sites' links cleaned and it's a bit more confusing when I can't just clear out the log when needed. But the option to show just the current tab would be better. |
Any feedback/suggestions on the current popup's appearance? @alekksander @jawz101 |
- Remove lots of cruff and margins - Make (top) buttons icons - Make big icon grayscale when CleanLinks disabled - Put help text in icon + toolip; as recommended by @alekksander - Put dirty/cleaned links together, above each other, so both are readable
@alekksander @jawz101 Care to try out the looks of the latest commit? |
i don't want to be the one that seems ungrateful and complains all the time, but if i had skills and free time i'd: thank You for Your work so far. |
Don't worry about it! I'm happy to get feedback, as I don't have strong opinions on the appearance anyway. Here's another update. |
just a bunch of ideas:
whitelist:
popup:
log:
currently viewed domaintab – not all work it has done so far. switch could be in settings, or on the opposite site of „Whitelist Selection button”The text was updated successfully, but these errors were encountered: