Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small improvements for the log, popup, and whitelist #19

Closed
6 tasks done
alekksander opened this issue May 30, 2018 · 9 comments
Closed
6 tasks done

small improvements for the log, popup, and whitelist #19

alekksander opened this issue May 30, 2018 · 9 comments
Labels
enhancement New feature or request

Comments

@alekksander
Copy link

alekksander commented May 30, 2018

just a bunch of ideas:

whitelist:

  • if domain is already white listed prevent from creating duplicates

popup:

  • it's size is too big, does it really has to be that big? top info if necessary could be ¼ of it's size, leaving more for the log. no point of such big font too i guess.
  • it doesn't scale right. on attachment you can see i can scroll the popup ifself (about 5px)
    clog
  • signify clearly when link tracking is disabled (e.g. grey out list)
  • clear list button as suggested by jawz101

log:

  • option to view cleaned links per currently viewed domain tab – not all work it has done so far. switch could be in settings, or on the opposite site of „Whitelist Selection button”
@Cimbali
Copy link
Owner

Cimbali commented May 30, 2018

You mean when a domain is whitelisted, remove all the items in the list with that domain? Because there shouldn't be new ones any way.

@alekksander
Copy link
Author

alekksander commented May 30, 2018

i've clicked 3 last entries from the screen shot in previous post and what i get is:
clog
as You can see collector.githubapp.com is added three times.

@Cimbali
Copy link
Owner

Cimbali commented Jun 6, 2018

Done part one. I'll try to get around to making the popup nicer, and filter the list by the current tab.

I think that makes more sense than current domain, in case some other/sub domain makes a request (through an iframe or whatnot).

@jawz101
Copy link

jawz101 commented Jun 15, 2018

Or at least a clear button on the log. As I browse around it accrues a laundry list of cleaned links. When I have an issue that needs whitelisting I have to sift through a bunch of old sites' links cleaned and it's a bit more confusing when I can't just clear out the log when needed.

But the option to show just the current tab would be better.

Cimbali added a commit that referenced this issue Jul 25, 2018
 Misses some prettification of popup, e.g. tab's main frame current
 domain name. Fixes last point of #19 and closes #18.
Cimbali added a commit that referenced this issue Jul 25, 2018
@Cimbali
Copy link
Owner

Cimbali commented Jul 25, 2018

Any feedback/suggestions on the current popup's appearance? @alekksander @jawz101

@alekksander
Copy link
Author

alekksander commented Jul 26, 2018

„Clear List” doesn't clear it until tabs are switched.

In general it's looking better. if You are asking for suggestions, here is mine to consider:
screenshot_20180726_101059
(sorry for ugly sketch)

Cimbali added a commit that referenced this issue Jul 31, 2018
- Remove lots of cruff and margins
  - Make (top) buttons icons
  - Make big icon grayscale when CleanLinks disabled
  - Put help text in icon + toolip; as recommended by @alekksander
- Put dirty/cleaned links together, above each other, so both are readable
@Cimbali
Copy link
Owner

Cimbali commented Jul 31, 2018

@alekksander @jawz101 Care to try out the looks of the latest commit?

@alekksander
Copy link
Author

alekksander commented Aug 1, 2018

i don't want to be the one that seems ungrateful and complains all the time, but if i had skills and free time i'd:
→fix it's width (when list is empty it's nice and small, when list contains something it gets too wide. perhaps cut it half?)
→shrink logo a bit, and leave about ⅔ of it's current size
→title and logo missing that 5px margins, that icon buttons has

thank You for Your work so far.

Cimbali added a commit that referenced this issue Aug 1, 2018
@Cimbali
Copy link
Owner

Cimbali commented Aug 1, 2018

Don't worry about it! I'm happy to get feedback, as I don't have strong opinions on the appearance anyway. Here's another update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants