Skip to content
This repository has been archived by the owner on Apr 13, 2019. It is now read-only.

cinch is not thread-safe #9

Closed
dcu opened this issue Aug 14, 2010 · 3 comments
Closed

cinch is not thread-safe #9

dcu opened this issue Aug 14, 2010 · 3 comments
Labels

Comments

@dcu
Copy link
Contributor

dcu commented Aug 14, 2010

it can fail if you use threads in plugins.
actually I think plugins(rules) should be executed in threads and maybe allow to set a timeout option

something like

Timeout.timeout(timeout_option) do
Thread.start do
blk.call(...)
end
end

@leejarvis
Copy link
Contributor

Unfortunately the current gem version of Cinch does not support Threads. We will soon be releasing version 1.0.0, which is likely to provide backwards incompatible changes, but will support threading inside plugins, and a nice modular plugin interface.

See here and check out the merge branch of Cinch to see what the new version will support. It will most likely be released in the next couple of days. Before updating please be sure to re-configure your Cinch based bots.

Thanks

@dominikh
Copy link
Member

To make things clear, we will not only support threading inside plugins, but plugins themselves will be executed in threads. Without any kind of timeout, though.

Imho, it's the responsibility of the plugin developer to take care of timeouts, especially because it will not hurt if a plugin call takes forever since they will be running concurrently, anyway.

@dcu
Copy link
Contributor Author

dcu commented Aug 15, 2010

ok I agree. so I should use the 'merge' branch for now..

@ghost ghost assigned dominikh and leejarvis Apr 10, 2011
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants