Fix SerialPort.getFlowControlMode() infinite recursion (openhab#4007)

An infinite recursion would occur when calling this method. I did not find any add-ons using this method but that could be due to this bug. Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
cipianpascu · Jan 17, 2024 · 76da465 · 76da465
1 parent 5932f44
commit 76da465
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/....javacomm/src/main/java/org/openhab/core/io/transport/serial/internal/SerialPortImpl.java b/....javacomm/src/main/java/org/openhab/core/io/transport/serial/internal/SerialPortImpl.java
@@ -206,7 +206,7 @@ public void notifyOnCarrierDetect(boolean enable) {
 
     @Override
     public int getFlowControlMode() {
-        return getFlowControlMode();
+        return sp.getFlowControlMode();
     }
 
     @Override

diff --git a/...t.serial.rxtx/src/main/java/org/openhab/core/io/transport/serial/rxtx/RxTxSerialPort.java b/...t.serial.rxtx/src/main/java/org/openhab/core/io/transport/serial/rxtx/RxTxSerialPort.java
@@ -206,7 +206,7 @@ public void notifyOnCarrierDetect(boolean enable) {
 
     @Override
     public int getFlowControlMode() {
-        return getFlowControlMode();
+        return sp.getFlowControlMode();
     }
 
     @Override