Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SerialPort.getFlowControlMode() infinite recursion #4007

Merged
merged 1 commit into from Jan 3, 2024
Merged

Fix SerialPort.getFlowControlMode() infinite recursion #4007

merged 1 commit into from Jan 3, 2024

Conversation

wborn
Copy link
Member

@wborn wborn commented Jan 3, 2024

An infinite recursion would occur when calling this method. I did not find any add-ons using this method but that could be due to this bug.

@wborn
Fix SerialPort.getFlowControlMode() infinite recursion
e0f6e95 
An infinite recursion would occur when calling this method.
I did not find any add-ons using this method but that could be due to this bug.

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn added the bug An unexpected problem or unintended behavior of the Core label Jan 3, 2024
@wborn wborn requested a review from a team as a code owner January 3, 2024 10:18
J-N-K
J-N-K approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@J-N-K J-N-K added this to the 4.2 milestone Jan 3, 2024
@J-N-K J-N-K merged commit 564d6e6 into openhab:main Jan 3, 2024
3 checks passed
@wborn wborn deleted the fix-infinite-recusion branch January 3, 2024 11:19
wborn added a commit that referenced this pull request Jan 3, 2024
@wborn
Fix SerialPort.getFlowControlMode() infinite recursion (#4007)
f71b062 
An infinite recursion would occur when calling this method.
I did not find any add-ons using this method but that could be due to this bug.

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn added the patch A PR that has been cherry-picked to a patch release branch label Jan 3, 2024
cipianpascu pushed a commit to cipianpascu/openhab-core that referenced this pull request Jan 17, 2024
@wborn
Fix SerialPort.getFlowControlMode() infinite recursion (openhab#4007)
76da465 
An infinite recursion would occur when calling this method.
I did not find any add-ons using this method but that could be due to this bug.

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wborn @J-N-K