Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check RMSF FWHM equation #33

Closed
Cameron-Van-Eck opened this issue Aug 11, 2020 · 1 comment
Closed

Check RMSF FWHM equation #33

Cameron-Van-Eck opened this issue Aug 11, 2020 · 1 comment
Labels
good first issue Good for newcomers

Comments

@Cameron-Van-Eck
Copy link
Collaborator

There are different versions of the prediction for RMWF FWHM. B&dB05 uses 3.47 in the numerator, Schnitzeler 2009 uses 3.8, Dickey 2019 uses 3.8.

Check the fitting results to see which is most accurate, then adjust the theoretical prediction to be more useful!
@Cameron-Van-Eck Cameron-Van-Eck added the good first issue Good for newcomers label Aug 11, 2020
@Cameron-Van-Eck
Copy link
Collaborator Author

Fixed today. Theoretical calculations were underestimating the width; fitting was overestimating the width. Fixed both to be more reliable in 'normal' conditions. May have introduced instability for extreme cases. If anyone has trouble when putting in an RMSF with very bad sidelobes, let me know so I can dig into it a bit deeper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Cameron-Van-Eck