Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Container Engine clarifications #2142

Merged
merged 20 commits into from
Mar 14, 2018
Merged

Google Container Engine clarifications #2142

merged 20 commits into from
Mar 14, 2018

Commits on Mar 9, 2018

  1. update code block languages

    @smart-alek
    smart-alek committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    04e0779 View commit details
    Browse the repository at this point in the history

  2. rewrite intro and remove whitespace

    @smart-alek
    smart-alek committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    ee45044 View commit details
    Browse the repository at this point in the history

  3. rewrite prerequisites

    @smart-alek
    smart-alek committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    90ffb01 View commit details
    Browse the repository at this point in the history

  4. add CircleCI 2.0 project as prerequisite

    @smart-alek
    smart-alek committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    75f2056 View commit details
    Browse the repository at this point in the history

  5. update bullet style

    @smart-alek
    smart-alek committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    c28a83d View commit details
    Browse the repository at this point in the history

  6. rewrite "Base Image" section

    @smart-alek
    smart-alek committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    ddab953 View commit details
    Browse the repository at this point in the history

  7. update product to google kubernetes engine

    @smart-alek
    smart-alek committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    87aa166 View commit details
    Browse the repository at this point in the history

  8. add links to authenticate GCP doc

    @smart-alek
    smart-alek committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    654f818 View commit details
    Browse the repository at this point in the history

  9. add additional environment variable section

    @smart-alek
    smart-alek committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    37e8f63 View commit details
    Browse the repository at this point in the history

  10. rename GOOGLE_AUTH

    @smart-alek
    smart-alek committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    f80100c View commit details
    Browse the repository at this point in the history

  11. clarify where to add variables

    @smart-alek
    smart-alek committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    a31dd23 View commit details
    Browse the repository at this point in the history

  12. update decode and store service account step

    @smart-alek
    smart-alek committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    c1cdd0e View commit details
    Browse the repository at this point in the history

  13. add dollar sign to env vars

    @smart-alek
    smart-alek committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    e80b32d View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2018

  1. various typos, newlines and sundry

    @smart-alek
    smart-alek committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    7aa9165 View commit details
    Browse the repository at this point in the history

  2. remove dollar signs 

    Environment variables should not be prefixed with dollar signs unless
they are used explicitly in a bash command.
    @smart-alek
    smart-alek committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    f1ddefb View commit details
    Browse the repository at this point in the history

  3. clean and clarify authentication step

    @smart-alek
    smart-alek committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    9348d1c View commit details
    Browse the repository at this point in the history

  4. minor typo in google auth doc

    @smart-alek
    smart-alek committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    69e6cf1 View commit details
    Browse the repository at this point in the history

  5. rewrite configuration walkthrough 

    Clarify why we're using "_json_key" as the username.
Properly indent steps within a deploy job.
    @smart-alek
    smart-alek committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    43207de View commit details
    Browse the repository at this point in the history

  6. add final commands for gcloud config

    @smart-alek
    smart-alek committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    79fd6ef View commit details
    Browse the repository at this point in the history

  7. be more explicit about auth differences for images

    @smart-alek
    smart-alek committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    1df2102 View commit details
    Browse the repository at this point in the history