Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exchange 2.7 Disabled Rule Correctly Configured Passes #126

Closed
rgbrow1949 opened this issue Jan 20, 2023 · 1 comment · Fixed by #130
Closed

Exchange 2.7 Disabled Rule Correctly Configured Passes #126

rgbrow1949 opened this issue Jan 20, 2023 · 1 comment · Fixed by #130
Assignees
@rgbrow1949
Labels
bug This issue or pull request addresses broken functionality
Milestone
Dolphin

Comments

@rgbrow1949
Copy link
Collaborator

Exchange Rego test 2.7 will pass if the rule is correctly configured but disabled. Will need to adjust Rego code to check if the rules are disabled or not.
@rgbrow1949 rgbrow1949 self-assigned this Jan 20, 2023
@buidav buidav added the bug This issue or pull request addresses broken functionality label Jan 20, 2023
@rgbrow1949
Copy link
Collaborator Author

I have made pull request #130 where the Rego will now only examine enabled rules if they are correctly configured or not. Now for 2.7 to pass there must be at least one correctly configured rule that is enabled.

@rgbrow1949 rgbrow1949 mentioned this issue Jan 23, 2023
Merged
12 tasks
@buidav buidav linked a pull request Jan 25, 2023 that will close this issue
EXO 2.7 Rego Bug Fix | Only Enabled Correctly Configured Rules Pass #130
Merged
12 tasks
@gdasher gdasher added this to the Dolphin milestone Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgbrow1949 rgbrow1949

Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Milestone
Dolphin
Development

Successfully merging a pull request may close this issue.

EXO 2.7 Rego Bug Fix | Only Enabled Correctly Configured Rules Pass cisagov/ScubaGear
3 participants
@gdasher @buidav @rgbrow1949