Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate State and Region Mapping #19

Closed
ameliav opened this issue Mar 7, 2024 · 1 comment
Closed

Consolidate State and Region Mapping #19

ameliav opened this issue Mar 7, 2024 · 1 comment
Assignees
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use

Comments

@ameliav
Copy link
Contributor

ameliav commented Mar 7, 2024

💡 Summary

Front-end:
The registration form contains a field for selecting US States and Territories. This dropdown is not alphabetized and should do so. This code will be consolidated in a "constants" file for both the organization form and registration form to use.

Back-end:
The database contains fields for state which displays abbreviated States, stateName which displays the full State, and regionId which is mapped based on the state. This logic should be consolidated to populate all these fields and is repeated for both User and Organization.

Motivation and context

To improve user experience, we need to sort the states alphabetically.

Implementation notes

Please provide details for implementation, such as:

  • The US States and Territories dropdown should display options in alphabetical order.
  • The sorting should be case-insensitive (e.g., “New York” should come after “North Carolina”).
  • The change should be reflected in both the organization form and the registration form.
  • Create a centralized function or module that handles state-related logic.
  • This function/module should populate the state, stateName, and regionId fields consistently for both User and Organization entities.
  • Ensure that the consolidated logic is efficient and maintainable.

Acceptance criteria

  • Commit to Integration Branch
  • Demonstrate functionality
  • Include Screenshots Of Updated Views
  • Commit to Staging
  • Create Functional Tests
@schmelz21 schmelz21 added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use development labels Mar 7, 2024
@ameliav
Copy link
Contributor Author

ameliav commented Mar 11, 2024

Blockers:

  • Pre-commit errors are not allowing the code to be committed and pushed up

Bugs:

  • The Crossfeed application used to show updated UI changes as soon as you refresh the browser. Currently, the changes will only show updates after fully stopping and starting the front-end docker container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Development

No branches or pull requests

3 participants