Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entra ID or AAD Functional test failures for MS.AAD.7.4v1 and MS.AAD.7.5v1 #1025

Closed
nanda-katikaneni opened this issue Mar 26, 2024 · 1 comment · Fixed by #1082
Closed
Assignees
Labels
bug This issue or pull request addresses broken functionality Testing This issue or task involves testing the automation tool function
Milestone

Comments

@nanda-katikaneni
Copy link
Collaborator

🐛 Summary

This issue was found through nightly product functional tests. Non-complaint test cases for MS.AAD.7.4v1 and MS.AAD.7.5v1 are failing on G5 and GCCHIGH tenants when run through GitHub action "Nightly functional product tests". However, the same tests are passing when run manually using a service principal. This issue and be used to debug and then fix the nightly product tests for aad.g5.testplan.yaml.

We have two service principals in the test tenants: GitHubActions and FunctionalTesting. GitHub actions use the first service principal app, while the dev team use the second app service for internal on-demand testing. Manually ran tests using both these apps with my certificate thumbprint - tests ran fine on g5 and gcchigh. But tests from GitHub actions are consistently failing non-complaint test cases for 7.4 and 7.5 policies. These policy test cases are run using run cached mode and are structured differently from the complaint test cases. These two policy test cases should be investigated further to make the nightly product test automation have clean runs.

To reproduce

Steps to reproduce the behavior:

  1. Run nightly product test GH action for the AAD G5 test plan.
  2. Observe results and failures for 7.4 and 7.5 policies.

Expected behavior

The nightly product functional testing using AAD G5 test plan should have a clean run with all tests being executed and passed.

Add any screenshots of the problem here.

@nanda-katikaneni nanda-katikaneni added bug This issue or pull request addresses broken functionality Testing This issue or task involves testing the automation tool function labels Mar 26, 2024
@schrolla schrolla added this to the Halibut milestone Apr 29, 2024
@tkol2022 tkol2022 self-assigned this Apr 30, 2024
@tkol2022
Copy link
Collaborator

tkol2022 commented Apr 30, 2024

The root cause for this was the functional test case hard coding the privileged_roles Assignments element [0] in the JSON array. That crashed in certain tenants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality Testing This issue or task involves testing the automation tool function
Projects
None yet
3 participants