Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.gitignore includes "Makefile", masking out Makefiles that are part of the distribution #30

Closed
michaellenaghan opened this issue Apr 29, 2016 · 4 comments
Closed

.gitignore includes "Makefile", masking out Makefiles that are part of the distribution #30

michaellenaghan opened this issue Apr 29, 2016 · 4 comments

Comments

@michaellenaghan
Copy link
Contributor

For example:
@michaelballantyne
Copy link

Including Makefile in .gitignore only hides any Makefile found in the top directory of the project; it does not apply to subdirectories. The .gitignore file would only hide the files you list if a pattern like **/Makefile was included.

The top-level Makefile is generated by the configure script, so hiding it is appropriate.

@michaellenaghan
Copy link
Contributor Author

Thanks, you're right; the problem was that my editor was applying .gitignore incorrectly.

@burgerrg
Copy link
Contributor

burgerrg commented May 2, 2016

The .gitignore file should use /Makefile instead of Makefile, just as you suggested. Thanks so much for finding this!

@burgerrg burgerrg reopened this May 2, 2016
burgerrg pushed a commit that referenced this issue May 2, 2016
resolved issue #30: gitignore specifies Makefile in all directories i…
7097480 
…nstead of just the root
@burgerrg
Copy link
Contributor

burgerrg commented May 2, 2016

Fixed in commit 7097480.

@burgerrg burgerrg closed this as completed May 2, 2016
spall pushed a commit to spall/ChezScheme that referenced this issue May 25, 2021
resolved issue cisco#30: gitignore specifies Makefile in all director…
d03d704 
…ies instead of just the root
mflatt pushed a commit to mflatt/ChezScheme that referenced this issue Oct 10, 2023
resolved issue cisco#30: gitignore specifies Makefile in all director…
f377bac 
…ies instead of just the root

Original commit: 7097480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@michaellenaghan @michaelballantyne @burgerrg