Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose language parameter #83

Closed
derekmpham opened this issue Nov 16, 2019 · 2 comments
Closed

Expose language parameter #83

derekmpham opened this issue Nov 16, 2019 · 2 comments
Assignees
@minhtuev

Comments

@derekmpham
Copy link

Not exposing non-English languages--implementing Vietnamese version of Kwik-E-Mart app. Need to expose language parameter in Application and ApplicationManager classes, as well as pass language parameter into nlp.process(). See PR #82
@minhtuev
Copy link
Contributor

Nice! This is a change that we really need and overlooked in the previous implementation!

@minhtuev minhtuev self-assigned this Nov 19, 2019
@minhtuev
Copy link
Contributor

We have changed the interface due so that we can add language and locale param for each NLP object directly. In the future, we might revisit setting a default language for an application when we add native support for multiple languages. We will descope this PR to simply add the Vietnamese version of Kwik E Mart.

#98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@minhtuev minhtuev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@minhtuev @derekmpham