[PATCH] Remove assignment of function parameter, which has no effect outside the function

[orbitcowboy]

Please review the attached patch, it removes an assignment of a function parameter, which has no effect outside function.

Here is the patch:

diff --git a/codec/decoder/plus/src/welsDecoderExt.cpp b/codec/decoder/plus/src/welsDecoderExt.cpp
index 65dd30a..eec4609 100644
--- a/codec/decoder/plus/src/welsDecoderExt.cpp
+++ b/codec/decoder/plus/src/welsDecoderExt.cpp
@@ -480,6 +480,5 @@ long CreateDecoder (ISVCDecoder** ppDecoder) {
 void_t DestroyDecoder (ISVCDecoder* pDecoder) {
   if (NULL != pDecoder) {
     delete (CWelsDecoder*)pDecoder;
-    pDecoder = NULL;
   }
 }

Best regards and many thanks

Martin Ettl

[kali2]

I think it is a good habit to set NULL when delete a point.

[orbitcowboy]

Since ISVCDecoder* pDecoder is provided by value, setting this pointer to NULL has no effect. Its simply a waste of time.

[ethanhugg]

Rolled into pull request #58