Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code should accept a path via cmdline / config and not assume working in '.' #25

Closed
bmenrigh opened this issue Jun 6, 2017 · 1 comment
Closed

Code should accept a path via cmdline / config and not assume working in '.' #25

bmenrigh opened this issue Jun 6, 2017 · 1 comment

Comments

@bmenrigh
Copy link
Contributor

bmenrigh commented Jun 6, 2017

Right now all of the file based operations (logging, PID file, daemonization) all assume paths are relative to '.' which isn't adequate for production. The daemonization code can't chdir to / right now for this reason.

It should be possible to specify a pidfile path and a logging directory path and a template file path. The code should also be able to continue functioning even after a chdir /
@bmenrigh
Copy link
Contributor Author

bmenrigh commented Jun 7, 2017

Done and merged with ec1be59

@bmenrigh bmenrigh closed this as completed Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bmenrigh