Add ending / to ensure the path-relative resources are referenced correctly #20
Conversation
Fix documentation root and failing node v14 15 tests
New version 0.1.0
Bump to v0.1.1
Bump to 0.2.0
Bump to 0.2.1
…rectly Without this change, the path-relative resources (/assets/...) attempt to get loaded from the root path, which is not where they exist and so a 404 is returned. This patch corrects the redirected location to ensure that it ends in `/` as then the path-relative resources will load from `/stable/assets` or `/dev/assets`, which is where they exist
|
In which browsers does this issue manifest? All modern browsers should automatically redirect from /dev to /dev/ and so on. Would like to test this reported behaviour. Does the issue described affect our site at https://citkane.github.io/typedoc-plugin-versions ? |
|
@toebeann This issue is in all browsers for me, could you try this site? https://formally-flexible-anemone.edgecompute.app |
|
Ah, this is likely a difference of server configuration. I suppose it does likely make the most sense for us to add this trailing slash to mitigate inconsistencies between servers. Could you please retarget this PR against the dev branch @JakeChampion ? |
|
@toebeann thanks - I have re-targeted it now |
|
Unfortunately our GitHub test workflow has missed this - supposedly because it wasn't initially targeting 'dev' when created. Closing and re-opening as it should be triggered on 'reopened' 🤞 |
|
There she goes |
|
Boom, green light across the board. Thanks for the contribution @JakeChampion. Short of any complications, I'll get this merged down and released to npm promptly 🚀 |
Without this change, the path-relative resources (/assets/...) attempt to get loaded from the root path, which is not where they exist and so a 404 is returned.
This patch corrects the redirected location to ensure that it ends in
/as then the path-relative resources will load from/stable/assetsor/dev/assets, which is where they exist