Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.2.2 #21

Merged
merged 3 commits into from
Nov 30, 2022
Merged

0.2.2 #21

merged 3 commits into from
Nov 30, 2022

Conversation

toebeann
Copy link
Collaborator

JakeChampion and others added 3 commits November 24, 2022 15:39
…rectly

Without this change, the path-relative resources (/assets/...) attempt to get loaded from the root path, which is not where they exist and so a 404 is returned.

This patch corrects the redirected location to ensure that it ends in `/` as then the path-relative resources will load from `/stable/assets` or `/dev/assets`, which is where they exist
Add ending / to ensure the path-relative resources are referenced correctly
@toebeann toebeann added the bug Something isn't working label Nov 29, 2022
@toebeann toebeann self-assigned this Nov 29, 2022
@toebeann
Copy link
Collaborator Author

@citkane would appreciate your eyeballs on this when you have the time

Copy link
Owner

@citkane citkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good,
Thanks @toebeann and @JakeChampion

@citkane citkane merged commit e26a3df into main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants