fix: normalize input paths on posix; simplify code a bit #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 84dd5dd.
timotheecour
changed the title
timotheecour
force-pushed
the
pr_fix_35_3
branch
from
ef14a0f
to
2263039
Compare
timotheecour
changed the title
timotheecour
changed the title
haltcase
changed the title
|
LGTM, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @citycide
reattempts #37 which had been reverted because it was causing issues on windows (due to lack of windows being tested back then)
note
I'm now only doing normalizedPath on posix, because it would cause complications on windows as it changes
/to\if someone needs a fix for #35 on windows, it can be handled in subsequent PR's; but right now the test suite is a bit weird for reasons unrelated to this PR: see #46
note2:
pathnorm.normalizePath might help with that but I don't want it in same PR, eg see
proc normalizePath*(path: string; dirSep = DirSep): string =