Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building "address" is a JSON object but Metadata "address" is string. #149

Closed
balazsdukai opened this issue Nov 22, 2022 · 7 comments
Closed
Milestone

Comments

@balazsdukai
Copy link
Member

"A City Object of type "Building", "BuildingPart" or "BuildingUnit" may have a member "address", consisting of an array of JSON objects listing one or more addresses of that building (an apartment building could contain several for instance). The properties of an address JSON object are free format, to accommodate the different ways addresses are described in different countries."

But the metadata.pointOfContact may have one member with the name "address". The value is a string with the full address.

Shouldn't we harmonize?

@hugoledoux
Copy link
Member

But aren't they already harmonised since both free format? I am not sure I follow you here.

@hugoledoux
Copy link
Member

Only the snippet I left the old xAL properties, I guess you meant that? Should we use the same properties as in the metadata you mean?

@balazsdukai
Copy link
Member Author

I meant that the Bulding* address has a value of JSON object, while the metadata address is a JSON string.
I think both should have the same value type, either string or object.

@hugoledoux
Copy link
Member

oh right I see now, stupid me...

We I think that would be too much of a break for a patch, no? But yes it should be harmonised, good point.

@balazsdukai
Copy link
Member Author

Yes, that's true. Let's keep this open for the next minor (or major) release.
Related to #137

@hugoledoux hugoledoux added this to the 2.0.0 milestone Apr 13, 2023
@hugoledoux
Copy link
Member

@balazsdukai I guess here the best would be to put metadata/pointOfContact as a json object, agreed?

@balazsdukai
Copy link
Member Author

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants