-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building "address" is a JSON object but Metadata "address" is string. #149
Comments
But aren't they already harmonised since both free format? I am not sure I follow you here. |
Only the snippet I left the old xAL properties, I guess you meant that? Should we use the same properties as in the metadata you mean? |
I meant that the Bulding* address has a value of JSON object, while the metadata address is a JSON string. |
oh right I see now, stupid me... We I think that would be too much of a break for a patch, no? But yes it should be harmonised, good point. |
Yes, that's true. Let's keep this open for the next minor (or major) release. |
@balazsdukai I guess here the best would be to put metadata/pointOfContact as a json object, agreed? |
Agreed. |
"A City Object of type "Building", "BuildingPart" or "BuildingUnit" may have a member "address", consisting of an array of JSON objects listing one or more addresses of that building (an apartment building could contain several for instance). The properties of an address JSON object are free format, to accommodate the different ways addresses are described in different countries."
But the
metadata.pointOfContact
may have one member with the name "address". The value is a string with the full address.Shouldn't we harmonize?
The text was updated successfully, but these errors were encountered: