Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sig_stat_pub.py is failing due to missing Socrautil Methods #230

Closed
johnclary opened this issue Jul 3, 2019 · 1 comment · Fixed by #231
Closed

Sig_stat_pub.py is failing due to missing Socrautil Methods #230

johnclary opened this issue Jul 3, 2019 · 1 comment · Fixed by #231
Assignees
Labels
Impact: 2-Major Causes a major interruption of ATD service delivery Service: Dev Infrastructure and engineering Workgroup: DTS Data and Technology Services
Milestone

Comments

@johnclary
Copy link
Member

As noted here. Socratautil is missing needed methods, causing this script to fail.

Once socrautil is patched, we simply need to rebuild the /tdp docker image and deploy.

@johnclary johnclary added this to the Sprint 2 milestone Jul 3, 2019
@johnclary johnclary self-assigned this Jul 3, 2019
@johnclary johnclary added Impact: 2-Major Causes a major interruption of ATD service delivery Service: Dev Infrastructure and engineering Workgroup: DTS Data and Technology Services labels Jul 3, 2019
@johnclary
Copy link
Member Author

johnclary commented Jul 3, 2019

Testing now with socratautil-dev v0.0.5. The method NotFoundError is resolved but now I'm getting a ValueError:

Traceback (most recent call last):
  File "sig_stat_pub.py", line 170, in <module>
    main()
  File "sig_stat_pub.py", line 160, in main
    replace=False,
  File "/usr/local/lib/python3.6/site-packages/socratautil/socratautil.py", line 65, in __init__
    self._handle_records()
  File "/usr/local/lib/python3.6/site-packages/socratautil/socratautil.py", line 74, in _handle_records
    self.records = mills_to_unix(self.records, self.date_fields)
  File "/usr/local/lib/python3.6/site-packages/datautil/datautil.py", line 126, in mills_to_unix
    raise ValueError
ValueError

I'm guessing this is related to new null value handling we implemented in socrautil v0.0.4. I apparently did not test this release enough. Sigh. Will have to revisit tomorrow :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impact: 2-Major Causes a major interruption of ATD service delivery Service: Dev Infrastructure and engineering Workgroup: DTS Data and Technology Services
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant