Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

Improvement Idea: restrict dynamic prompt args list as much as possible to prompt #82

Closed
metachris opened this issue Nov 10, 2017 · 5 comments

Comments

@metachris
Copy link
Contributor

Opening this for discussion.

I understand the prompt needs to read generic input strings. I think it would be beneficial to add function signatures as soon as possible, and restrict this dynamic args list to prompt.py as much as possible.

For instance neo.Prompt.Commands.LoadSmartContract.LoadContract: Instead of def LoadContract(args): it could/should be def LoadContract(path, params, return_type, needs_storage):

This would make the code a lot easier to understand, and also more resilient to errors and bugs.

@localhuman
Copy link
Collaborator

Agreed, would be easier to document as well :)

@ixje
Copy link
Member

ixje commented Nov 20, 2017

needs milestone please

@ixje
Copy link
Member

ixje commented Jun 11, 2018

is this still a valid issue/something to keep in mind? @metachris

@metachris
Copy link
Contributor Author

Yes, I think this would still be an improvement.

@ixje ixje removed this from the Milestone v0.5.0 milestone Aug 1, 2018
@ixje
Copy link
Member

ixje commented Dec 12, 2018

Cleaning up issues and we're moving to a different CLI command structure.

@ixje ixje closed this as completed Dec 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants