Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BooleanWitnessCondition has no serialize method override #876

Closed
xie-yue opened this issue Nov 8, 2022 · 4 comments · Fixed by #877
Closed

BooleanWitnessCondition has no serialize method override #876

xie-yue opened this issue Nov 8, 2022 · 4 comments · Fixed by #877

Comments

@xie-yue
Copy link

xie-yue commented Nov 8, 2022 •
edited
Loading

in BooleanWitnessCondition

there is no serialize method override, so expression didn't work.
for deserialize read byte for expression, next step deserializeAttributes throws en error 11 not found in TxAttrUsage!

related
#872
@ixje
@ixje ixje mentioned this issue Nov 8, 2022
Merged
@ixje
Copy link
Member

ixje commented Nov 8, 2022

Sorry to see that. Hopefully the above PR fixes all remaining issues with WitnessConditions.

As for deserializeAttributes. That's a separate issue. Transaction attributes are something only committee members can set and as a result hardly ever seen. The current implementation is actually still based on NEO2

@xie-yue
Copy link
Author

xie-yue commented Nov 8, 2022

@ixje
the pr works perfectly in my local environment, waiting for merge.
thank you very much!

@ixje ixje mentioned this issue Nov 8, 2022
Merged
@ixje
Copy link
Member

ixje commented Nov 11, 2022

@xie-yue fyi; https://www.npmjs.com/package/@cityofzion/neon-js/v/5.2.2

@xie-yue
Copy link
Author

xie-yue commented Nov 14, 2022

works great! thx! @ixje

@xie-yue xie-yue closed this as completed Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tx): WitnessCondition serialization & toJson fixes
2 participants
@xie-yue @ixje