Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table data json format #6

Closed
sannailtanen opened this issue May 7, 2019 · 5 comments
Closed

table data json format #6

sannailtanen opened this issue May 7, 2019 · 5 comments
Assignees

Comments

@sannailtanen
Copy link
Collaborator

Is there a gama model that reads the table data in 'CityIO Data Structure Standard version 2.1' format?

@agrignard
Copy link
Contributor

Dear @sannailtanen

There is indeed a generic GAMA model reading and writing to cityIO using the 2.1 format that can be found here
https://github.com/CityScope/CS_CityIO_Backend/tree/master/examples/GAMA/cityIO_Gama

@doorleyr doorleyr self-assigned this May 13, 2019
@doorleyr
Copy link
Collaborator

I edited the code using @agrignard 's suggestion so now it can read from the Aalto table in the current format. However, the type numbers being sent by the Aalto table don't match what the simulation is looking for. So for now, the code is just reading from a sample json file which I saved as cityIO_Aalto.json. Once the scanner is sending the right data, we can change it back to reading the live table.
@sannailtanen can you look at the Gama code where citymatrix_map_settings is defined (line 48) and make sure that the data sent by the table is in line with this. You can change the data being sent to cityIO or the GAMA code or both.
Also, the position of the grid is still hardcoded in the wrong position. You need to change the constants "angle" and "center" in order to place the grid in whatever position you need.

@doorleyr doorleyr assigned sannailtanen and unassigned doorleyr May 13, 2019
@doorleyr
Copy link
Collaborator

Closing and creating new issues for the grid position and type inconsistency.

@agrignard
Copy link
Contributor

agrignard commented May 16, 2019

"I edited the code using @agrignard 's suggestion so now it can read from the Aalto table in the current format. " @doorleyr would it be possible to point to the right commit in order to see and track what are the modification made?

I insist again on the genericity of the model developped in GAMA and raises a warning that this is very dangerous and not productive to duplicate the code of the CS_Simulation_GAMA or cityIO in this repo. The hole point of the CS_Simulation_GAMA or cityIOGama is to have a generic model that 1. can be used by other city (like you are doing) and 2. can be enhanced/improve modify by this city in order to improve the model itself.

Right now the modification done are only benefical for Helsinki and doesn't benefit for the rest of the network.

@doorleyr how difficult would it be to integrate (first by asking in an issue and two proposing a pull request) those change in order to integrate it directly in the original model? I want to insist on this because it will be more and more difficult not to say impossible to keep the track on the 2 models.

@agrignard agrignard reopened this May 16, 2019
@doorleyr
Copy link
Collaborator

doorleyr commented Jun 5, 2019

The Aalto Gama model is now living in the CS_Simulation_GAMA repo so closing this issue.

@doorleyr doorleyr closed this as completed Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants