Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to sacrifice units with the Soothsayer #28

Closed
the-m4a opened this issue Jun 7, 2020 · 3 comments · Fixed by #35
Closed

Unable to sacrifice units with the Soothsayer #28

the-m4a opened this issue Jun 7, 2020 · 3 comments · Fixed by #35
Assignees
Labels
bug Something isn't working

Comments

@the-m4a
Copy link
Collaborator

the-m4a commented Jun 7, 2020

Investigate:
From the Workshop page:

This mod makes it so I'm unable to sacrifice units with the soothsayer during the Appease The Gods emergency. This is the only bug I've come across so far, but it is annoying having to disable the mod whenever the emergency pops up

@the-m4a the-m4a self-assigned this Jun 8, 2020
@the-m4a
Copy link
Collaborator Author

the-m4a commented Jun 8, 2020

Reproduced this issue - click on the button for "Sacrifice Adjacent Unit" and nothing happens. Looks like there's some stuff in WorldInput.lua and UnitPanel.lua to integrate

@the-m4a
Copy link
Collaborator Author

the-m4a commented Jun 8, 2020

oof. worldinput.lua needs some work. lots of differences in the CQUI version and the in-game version

@the-m4a
Copy link
Collaborator Author

the-m4a commented Jun 8, 2020

In spite of that needed work, it was at least fairly easy to enable the Sacrifice stuff. It seems to work, though I did not get a significant chance to test it.
I started up a game as the Maya in Apocolypse mode. Let it autoplay for 50 turns, then about 20 turns at a time until I finally got to a point where an Appease the Gods emergency was going on. Dropped a soothsayer and couple of units next to Kilamenjaro and was able to sacrifice.
The score of the emergency doesn't update immediately, but it does the next turn (which is fairly standard for those things I think).

The code changes are in this branch - no PR yet, as I want to ensure the other PR gets done first.
https://github.com/civfanatics/CQUI_Community-Edition/tree/SoothsayerSacrificeFix

@the-m4a the-m4a added the bug Something isn't working label Jun 8, 2020
@alimulhuda alimulhuda linked a pull request Jun 14, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant