CRM-20237 Don't add in extra copy of ids and only use most recent id … #10929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…copied from in title and don't put copy of details in name for pricesets
|
The title is a clear improvement.
vs However, I think it's nice to keep some of the title in the name - currently we are seeing
I think this is nicer gives the second version |
|
@eileenmcnaughton yep happy with that have cherry-picked and updated tests |
|
OK - - we'll need to find another merge now I've collaborated - @totten @colemanw @monishdeb - any of you able to merge this if is passes? (or give merge on pass) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…copied from in title and don't put copy of details in name for pricesets
Overview
Previously when copying a price set it would just continuouly add in copy_id_x etc onto the end of the name and title. Now it only adds the most recent price set id on the title the name is just the new id with Price_set
@eileenmcnaughton does this make sense to you?