CRM-21393: Event checkPermission should only check the specific event… #11242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, if eventId was passed (for performance).
|
That is a ridiculously complicated function for what it does. But it makes sense that you wouldn't need to fetch all events just to check permissions for one event. |
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
CRM-21393: Event checkPermission should only check the specific event…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…, if eventId was passed (for performance).
(copied from JIRA):
On a fairly normal site, with 2500 events, I noticed that loading any Event > Location page took 8 seconds for the full page load, where as normally pages take up to 2 seconds to load. This is in great part caused by the XHR/AJAX loading of various bits on the screen, which each took about 2 seconds to load. Still, XHR requests are normally pretty quick (600 ms).
Using php-xdebug profiling, I narrowed it down to CRM_Event_BAO_Event::checkPermission().