CRM-21468: mailing recipients field limits how many groups can be selected #11349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When creating a mailing, the mailing recipients group currently limits how many groups (or mailings) can be selected. It appears that the option in search preferences for "autocomplete results" is not only determining how many records appear in the search result dropdown at a time, but also limits how many options can be selected. It should not be doing that. We should also do a bit of investigation to see if that behavior is impacting other instances of the Select2 widget.
Before
Based on count set for "autocomplete results" say 2, you can select only two recipient groups in 'New Mailing' screen.
After
Irrespective of count set for "autocomplete results", you can choose any number of recipient groups.
Technical Details
Issue encountered due to changes made to getlist API where it took the default value for limit from
search_autocomplete_count
setting and this is point. As per the fix, we are overriding limit with 0/unlimited.