Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-21468: mailing recipients field limits how many groups can be selected #11349

Merged
merged 1 commit into from
Dec 1, 2017

Conversation

monishdeb
Copy link
Member

@monishdeb monishdeb commented Nov 30, 2017

Overview

When creating a mailing, the mailing recipients group currently limits how many groups (or mailings) can be selected. It appears that the option in search preferences for "autocomplete results" is not only determining how many records appear in the search result dropdown at a time, but also limits how many options can be selected. It should not be doing that. We should also do a bit of investigation to see if that behavior is impacting other instances of the Select2 widget.

Before

Based on count set for "autocomplete results" say 2, you can select only two recipient groups in 'New Mailing' screen.

After

Irrespective of count set for "autocomplete results", you can choose any number of recipient groups.

Technical Details

Issue encountered due to changes made to getlist API where it took the default value for limit from search_autocomplete_count setting and this is point. As per the fix, we are overriding limit with 0/unlimited.


@monishdeb
Copy link
Member Author

ping @lcdservices

@lcdservices
Copy link
Contributor

@monishdeb this looks good. we can now add more groups/mailings to a mailing than what is configured in the search results list config option. @colemanw can you review.

@colemanw colemanw merged commit bb6dbcd into civicrm:master Dec 1, 2017
@monishdeb monishdeb deleted the CRM-21468 branch December 7, 2017 08:17
sluc23 pushed a commit to ixiam/civicrm-core that referenced this pull request Jan 10, 2018
CRM-21468: mailing recipients field limits how many groups can be selected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants