dev/core#357 Fix issue where user email addresses were keyed on email… #12828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not id therefore breaking the usage of the signature option on email addresses and ensure that emails still get passed through correctly
|
Thank you so much for fixing the issue. I did a QA on current state of the code and it fixes the problem for signature. However i haven't checked and QA'd for the previous issue for which it was fixed. Before:
After:
|
|
Jenkins re test this please |
|
@seamuslee001 This is on my list, not sure when I'll get to it though hopefully in next couple of days. |
|
@pradpnayak @mattwire this needs another look |
|
I did a quick test today and it seems to work for me. Signature is displayed on New Email form. Good to merge unless @mattwire have any concerns! |
|
test this please |
|
Thanks @pradpnayak - you should be here! Merge on pass |
|
@eileenmcnaughton @pradpnayak Fine by me to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… not id therefore breaking the usage of the signature option on email addresses and ensure that emails still get passed through correctly
Overview
User record supplied email addresses were keyed on the email not id breaking the signature element this fixes it and ensures we are still returning sensible format to the relevant function.
Before
Email Signature broken
After
Email Signature Fixed
ping @pradpnayak @mattwire would one of you be able to test this?