dev/core#619 fix regression on Address contact-reference fields not rendering results #13385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endering results. Fixing results not rendering on onbehalf profiles broke addresses - this limits the handling added for onbehalf to only apply to onbehalf.
|
(Standard links)
|
|
I'm ok with this as it seems pretty limited and fixes a regression adding merge on pass |
|
Thank you @eileenmcnaughton and @seamuslee001 |
|
Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a regression whereby contact reference fields on addresses were not loading options in the autoselect. This arose from a 5.7 fix to the contact reference field in on-behalf profiles
Before
After
Technical Details
limits the handling added for onbehalf to only apply to onbehalf.
Comments
@alifrumin @pradpnayak