Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed unwanted parameter from getLineItems() #13479

Merged
merged 1 commit into from
Jan 17, 2019
Merged

removed unwanted parameter from getLineItems() #13479

merged 1 commit into from
Jan 17, 2019

Conversation

pradpnayak
Copy link
Contributor

Overview

getLineItems() function params was changed at 77dbdcbc288#diff-e57ed384488b5985e5a0a5c166a6b0f0R199 but was missed to update getLineItemsByContributionID() function

@civibot
Copy link

civibot bot commented Jan 17, 2019

(Standard links)

@civibot civibot bot added the master label Jan 17, 2019
@pradpnayak
Copy link
Contributor Author

@eileenmcnaughton ping!

@eileenmcnaughton
Copy link
Contributor

I agree this looks like an oversight - good work @pradpnayak

@seamuslee001
Copy link
Contributor

Jenkins re test this please

@eileenmcnaughton
Copy link
Contributor

test this please

@monishdeb
Copy link
Member

merging as per tag

@monishdeb monishdeb merged commit 28df323 into civicrm:master Jan 17, 2019
@pradpnayak pradpnayak deleted the cruftCode branch March 23, 2020 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pradpnayak @eileenmcnaughton @seamuslee001 @monishdeb