Fix regression whereby making receive_date required breaks back office cc

[eileenmcnaughton]

Overview

Regression from https://lab.civicrm.org/dev/core/issues/680
led to https://civicrm.stackexchange.com/questions/28410/unable-to-take-credit-card-payment-after-civi-update

Before

error message staing 'Date Received is a required field.'

After

not required when cc is present

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@eileenmcnaughton is there a corresponding PR for 5.11?

[eileenmcnaughton]

@seamuslee001 ah good point - I'll do one - I just wanted to get this merged ASAP so it can go out as it's urgent

[seamuslee001]

(CiviCRM Review Template WORD-1.2)

• General standards
  • (r-explain) Pass
  • (r-user) Pass
  • (r-doc) Pass
  • (r-run) Pass replicated the issue and confirmed this fixes the issue whilst still fixing the problem with the non credit card form
• Developer standards
  • (r-tech) Pass
  • (r-code) Pass
  • (r-maint) Pass
  • (r-test) Unknown

[seamuslee001]

Test failures unrelated merging