Menu bar - Allow customization. Restore default colors.

[colemanw]

Overview

v5.12 introduced a new menu bar. The change also revised the default color scheme (applying a more contemporary palette), but this creates stress for some users who were trained to recognize the old menu color.

This exposes a new setting for customizing the color scheme, and it changes the default to match previous scheme.

Before

Menubar color hardcoded to #f2f2f2

After

Menubar color defaults to #1b1b1b (consistent with previous versions of CiviCRM) and is configurable via "Display Settings" screen:

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

FYI @Stoob @totten @mattwire @agh1

[seamuslee001]

@colemanw can you pls rebase this against current master pls

[Stoob]

The configurable color setting is fresh, thx @colemanw

@agh1 I don't have a large sample size of reactions to go on. But I think that defaulting to the old grey menu bar color is also a safer move.

But this is with the caveat that regardless of the default this cool feature should be combined with a popup that says "hey you can change your menu bar color now (link to config page, above)". Let's show this off a bit! This is akin to the experience I've seen in other software where it's says "hey would you like to try our new look"?

[MegaphoneJon]

Personally, I'm mostly excited by the ability to put a toolbar color into civicrm.setting.php to differentiate my test sites more easily :)

[colemanw]

Yep that is one upshot of this change :)
As @MegaphoneJon astutely observed, the menu color is now a setting, and settings can be overridden by your config files, and you can have different config files on e.g. your staging and test servers.

[colemanw]

@agh1 I've added a validate callback to the setting so the api won't let you save anything that isn't a properly formed 7-character hex color.
@Stoob or @agh1 can you review this PR?

[totten]

(CiviCRM Review Template WORD-1.2)

• General standards
  • (r-explain) Pass: Tweaked a bit to add context. The explanation is still a little cheeky, but that picture is so clever... :)
  • (r-user) Pass: Improves r-user for a recent enhancement.
  • (r-doc) Pass
  • (r-run) Pass: I locally tried it out using a mix of of production-mode/debug-mode and color-schemes, with changes made via web UI and CLI. All worked as expected.
• Developer standards
  • (r-tech) Pass
  • (r-code) Pass: I have another very small tweak, but it can wait in a separate PR. More important to get this moving so we can branch the RC.
  • (r-maint) Pass
  • (r-test) Pass: There are reported failures, but these appear unrelated.

[zkrebs]

I think the image should also reflect a male figure in a state of distress and also drop the lines about "inclusivity". I'd like to be able to forward this to my predominantly female coworkers who believe in GLBTQQ inclusivity, etc.

Sorry to be that person. I laughed, but I am also realistic that this could make someone dislike CiviCRM.

[Stoob]

Ok @zkrebs by the way it was not the intent to have that image publicly published, originally posted it on the partners private channel. Come to think of it, perhaps it should be removed from this page @colemanw

[zkrebs]

Understood. Thanks for everyone's hard work to get these features done.

[colemanw]

It's the first time I've heard someone argue we need more male representation in this field, but sure. I've cleaned up the PR description to be more straightforward and removed the image, which was a joke and so probably not the most "professional" thing to put on a PR :)