Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbunit test] remove dbunit dependency #14328

Merged
merged 1 commit into from
May 25, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented May 25, 2019

Overview

Finally remove dbunit from extends

Before

Discontinued package in use

After

dbunit gone

Technical Details

Comments

@civibot
Copy link

civibot bot commented May 25, 2019

(Standard links)

@civibot civibot bot added the master label May 25, 2019
@seamuslee001
Copy link
Contributor

well that worked @eileenmcnaughton

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 so you think this is all good / resolves the package? If so I'll fix up the pr template & you can merge

@seamuslee001
Copy link
Contributor

@eileenmcnaughton I think so but not 100% sure tho i would say likely yes

@@ -244,7 +245,6 @@ public static function getDBName() {
* @return PHPUnit_Extensions_Database_DB_IDatabaseConnection connection
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eileenmcnaughton this may need to be cleaned up

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 do you want to merge #14321 (has an unrelated fail but passed) & I'll rebase this & fix the comment & you can mull it until Monday or so

@seamuslee001
Copy link
Contributor

Done

@seamuslee001
Copy link
Contributor

This only affects tests and Jenkins has oked it, also the time taken was within normal range merging

@seamuslee001 seamuslee001 merged commit 7c295e8 into civicrm:master May 25, 2019
@seamuslee001 seamuslee001 deleted the dbunit branch May 25, 2019 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants