-
-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dbunit test] remove dbunit dependency #14328
Conversation
(Standard links)
|
well that worked @eileenmcnaughton |
@seamuslee001 so you think this is all good / resolves the package? If so I'll fix up the pr template & you can merge |
@eileenmcnaughton I think so but not 100% sure tho i would say likely yes |
@@ -244,7 +245,6 @@ public static function getDBName() { | |||
* @return PHPUnit_Extensions_Database_DB_IDatabaseConnection connection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eileenmcnaughton this may need to be cleaned up
@seamuslee001 do you want to merge #14321 (has an unrelated fail but passed) & I'll rebase this & fix the comment & you can mull it until Monday or so |
Done |
This only affects tests and Jenkins has oked it, also the time taken was within normal range merging |
Overview
Finally remove dbunit from extends
Before
Discontinued package in use
After
dbunit gone
Technical Details
Comments