dev/core#980 [dbunit] remove dependency on discontinued dbunit

[eileenmcnaughton]

Overview

Remove obsolete phphunit/dbunit package from our test suite

sebastianbergmann/dbunit#217

Removing our dependency on this removes a hurdle in supporting more recent phpunit versions since we need to migrate over our own classes to extend the namespaced classes, but currently they extend a dbunit class so getting rid of that is a first useful step.

Before

phpunit/dbunit used in tests

After

phpunit/dbunit not used in tests

Technical Details

I came into this as the path to updating our phpunit version expectations requires us to start changing how we call phpunit & the path for this is much less clear ... and then it stops

The phpunit/dbunit package has been discontinued. I've removed the reference to it from the top level
extends and one call to it & the test I tried locally passes so it's not needed for ALL tests.

Let's see where it IS needed & what our options are - have at it jenkins

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[seamuslee001]

@eileenmcnaughton seems to be a problem

RUN:[[./scripts/phpunit --tap --log-junit '/home/jenkins/workspace/CiviCRM-Core-PR@3/junit/CRM_AllTests.xml' '--exclude-group' 'ornery' 'CRM_AllTests']]
TAP version 13
DB_DataObject Error: No database name / dsn found anywhere

[eileenmcnaughton]

@seamuslee001 odd because it only failed on the cachekey last run

[seamuslee001]

@eileenmcnaughton no it also failed on that previously if you clicked on test result you will have seen about 2000 tests missed because there was no xml file for it

[eileenmcnaughton]

hmm I don't see any skipped yet this run - will wait

[seamuslee001]

@eileenmcnaughton you can see here https://test.civicrm.org/job/CiviCRM-Core-PR/26404/testReport/ the test result is missing about 2000 tests and in the console log it has

Found EXITCODES=""
Check test results and set exit code
Missing XML: CRM_AllTests.xml

i think this will fix the CRM tests

diff --git a/tests/phpunit/CiviTest/CiviUnitTestCase.php b/tests/phpunit/CiviTest/CiviUnitTestCase.php
index ca7390a1e8..3de4f1ce4f 100644
--- a/tests/phpunit/CiviTest/CiviUnitTestCase.php
+++ b/tests/phpunit/CiviTest/CiviUnitTestCase.php
@@ -60,6 +60,12 @@ class CiviUnitTestCase extends PHPUnit_Framework_TestCase {
   use \Civi\Test\ContactTestTrait;
   use \Civi\Test\MailingTestTrait;

+  /**
+   *  Database has been initialized.
+   *
+   * @var bool
+   */
+  private static $dbInit = FALSE;

   /**
    * The database name.
@@ -281,8 +287,12 @@ class CiviUnitTestCase extends PHPUnit_Framework_TestCase {
       exit(1);
     }

+    self::getDBName();
     // reload database before each test
-    //        $this->_populateDB();
+    if (!self::$dbInit) {
+      $this->_populateDB();
+      self::$dbInit = TRUE;
+    }

     // "initialize" CiviCRM to avoid problems when running single tests
     // FIXME: look at it closer in second stage

[eileenmcnaughton]

@seamuslee001 OK I see now .- I've pulled this back to just deal with the YAML to get that out of the way - your suggestion didn't work for me - but I only had a quick go at it.

I see the issue is that the dataprovider is being called before the test set up & in that flow the initiation is missing

[seamuslee001]

Test fail is unrelated changes work merging