Don't apply api3 pre/post processing to api4 actions #14357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transactions aren't a bad thing and we probably want to revisit this but for now I'm disabling it becuase it's broken, as seen in api_v3_ActivityTest. I think the problem is with the onApiException event not being dispatched because api4 doesn't go through Kernel->runSafe, so transactions aren't being rolled back when they should.
|
(Standard links)
|
|
@eileenmcnaughton this is extracted from #14153 and fixes some issues with api4 tests. |
colemanw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes some api3 specific handling of api4 actions.
Before
Some unexpected bugs in api4 being caused by extra api3 processing.
After
Api4 is faster and less buggy.