Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Exception to remove result from duplicates #14447

Merged
merged 1 commit into from
Jun 7, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jun 6, 2019

Overview

This updates, and tests, the Exception.create function (via the api) to remove duplicates from the
prevnext_cache. This feels like a better fix than the cartwheels the prevnext cache code does to avoid
retrieving cached duplicates.

Before

Marking a non-duplicate does not remove from cached duplicates table (although it is excluded on retrieve I have some doubts as to whether that works reliably when the pair has been flipped)

After

Cached contacts removed

Technical Details

This feels like a more reliable approach to me. I didn;'t go down the path of proving whether there was an issue with existing code when flipped as I think this is worth doing anyway

Comments

@civibot
Copy link

civibot bot commented Jun 6, 2019

(Standard links)

@civibot civibot bot added the master label Jun 6, 2019
This updates, and tests, the Exception.create function (via the api) to remove duplicates from the
prevnext_cache. This feels like a better fix than the cartwheels the prevnext cache code does to avoid
retrieving cached duplicates.
@eileenmcnaughton
Copy link
Contributor Author

test this please

@eileenmcnaughton
Copy link
Contributor Author

@pfigel I'm not sure if you have a specific interest in my efforts to make dedupe functionality api-accessible but it you do - here is another...

@pfigel
Copy link
Contributor

pfigel commented Jun 7, 2019

@eileenmcnaughton yep, we'll probably need to work on our deduping process at some point this year, so anything making that more accessible to extensions is greatly appreciated!

  • General standards
    • (r-explain) PASS
    • (r-user) PASS: Provides a more stable implementation of the same behaviour from the user's point of view, no user impact.
    • (r-doc) PASS
    • (r-run) PASS: Confirmed exceptions are removed from civicrm_prevnext_cache after API call.
  • Developer standards

@seamuslee001 seamuslee001 merged commit 61debb3 into civicrm:master Jun 7, 2019
@seamuslee001 seamuslee001 deleted the exception branch June 7, 2019 08:14
@eileenmcnaughton
Copy link
Contributor Author

@pfigel we'd definitely love to collaborate with you on it - this is the extension I've been working on - https://github.com/eileenmcnaughton/org.wikimedia.dedupetools - trying to make the manual process more efficient since we already have a bunch auto-deduped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants