Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] export - add unit test covering merge to same address addressee handling #14817

Merged
merged 3 commits into from
Jul 13, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Adds a unit test for the weird & wonderful code that handles the address fields on merge same address (not that much of the wondeful)

Before

No test

After

Test

Technical Details

Comments

@civibot
Copy link

civibot bot commented Jul 12, 2019

(Standard links)

@civibot civibot bot added the master label Jul 12, 2019
@colemanw
Copy link
Member

@eileenmcnaughton test falls over on Undefined property: CRM_Export_BAO_ExportProcessor::$contactGreetingFieldss
Looks like a typo with the extra s at the end of that variable name.

@eileenmcnaughton
Copy link
Contributor Author

@colemanw green tick now

@colemanw colemanw merged commit 4461a85 into civicrm:master Jul 13, 2019
@colemanw colemanw deleted the export_up branch July 13, 2019 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants