(dev/core#1065) Member in Edit mode needs to be shown consistently #15362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Jenkins test this please |
1 similar comment
|
Jenkins test this please |
|
@eileenmcnaughton This is in sync with #15321 |
|
I just tested this & added screen shots above. I think it would be better to show display name than sort name but this is consistent with other places & I think the advantage of a clickable link outweighs that concern. I also tested in standalone mode - merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Member in Edit mode needs to be shown in consistency with Grant screen.
Before
Display name is hardcoded freeze value
After
Display name is clickable contact name.