[REF] remove call to deprecated function #15465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
getPartialPaymentType basically just calls CRM_Contribute_BAO_Contribution::getContributionBalance & then returns the balance in a different array key depending on the value. This switches to calling it directly & completes the work of removing all calls to it & more heavily deprecating it
eileenmcnaughton
force-pushed
the
dep_fn
branch
from
432e127
to
a168b22
Compare
|
Refactor looks right to me merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes a call to a confusing deprecated function & deprecates it more aggressively
Before
Squirrels feasting
After
Squirrels on dry rations
Technical Details
getPartialPaymentType basically just calls CRM_Contribute_BAO_Contribution::getContributionBalance
& then returns the balance in a different array key depending on the value.
This switches to calling it directly & completes the work of removing all calls to it & more heavily deprecating it
Comments