Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/membership#21 fix bug where inherited memberships get inappropriately deleted #16139

Closed
wants to merge 1 commit into from
Closed

dev/membership#21 fix bug where inherited memberships get inappropriately deleted #16139

wants to merge 1 commit into from

Commits on Dec 22, 2019

  1. Find all the tests that rely on ad-hoc resetting of this static 

    Remove static from createRelatedMemberships

If you do 2 updates on a membership it can result in related memberships being deleted as they are treated as
'already processed'. This static was added to prevent a loop a la https://issues.civicrm.org/jira/browse/CRM-4213

However, we need a better method - ie a DB lookup because this has caused ongoing related bugs - latest being
https://lab.civicrm.org/dev/membership/issues/21 because it's too clunky & unreliable
    @eileenmcnaughton
    eileenmcnaughton committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    2ddc825 View commit details
    Browse the repository at this point in the history