Remove deprecated parameter

[eileenmcnaughton]

Overview

This parameter was deprecated a while back - we obviously used caution at the time
but we can remove it now

Before

Function signature is

public static function recordMembershipContribution(&$params, $ids = []) {

but $ids is unused & deprecated

After

function signature is

public static function recordMembershipContribution(&$params) {

Technical Details

Generally we leave a deprecation notice for a minimum of 6 months & then clean up deprecated code ad hoc - this has served it's time

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).