Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Deprecate passing in silly data #16818

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Later we can move to requiring an integer

Before

We quietly accept the function being called with no id

After

We noisily accept the function being called with no id

  • We would also like to do strict type casting but for now let's at least ensure it's numeric

Technical Details

Comments

Later we can move to requiring an integer
@civibot
Copy link

civibot bot commented Mar 17, 2020

(Standard links)

@civibot civibot bot added the master label Mar 17, 2020
@seamuslee001
Copy link
Contributor

Yeh this makes sense to me merging

@seamuslee001 seamuslee001 merged commit 4d9b920 into civicrm:master Mar 17, 2020
@seamuslee001 seamuslee001 deleted the del branch March 17, 2020 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants